Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views Web UI #15385

Merged
merged 127 commits into from
Jan 10, 2022
Merged

Views Web UI #15385

merged 127 commits into from
Jan 10, 2022

Conversation

adityamukho
Copy link
Contributor

@adityamukho adityamukho commented Dec 20, 2021

Note: This PR is large, since during development of this feature, a lot of UI components that were common to both Analyzers and Views were created/updated. Unfortunately, this led to unavoidable changes to several files in the Analyzers Web UI section, that otherwise have no functional bearing on this feature.

The functionality of the Analyzers UI should remain unaffected, since from the perspective of that section, this PR only introduces functionally invariant code refactors.

Scope & Purpose

This PR enhances the 'Views' section of the AARDVARK UI for ArangoDB, making it feature-complete, i.e. every field/property of an ArangoSearch View can now be configured through forms in the UI, in addition to the already existing method of editing the raw JSON representation. This includes the ability to configure View Links, with full support for their nested/recursive structures. Additionally, the JSON form has been improved with a schema validator, which informs the user of any errors in their JSON input.

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • Backport for 3.9: (Please link PR)
  • Backport for 3.8: (Please link PR)
  • Backport for 3.7: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run: https://jenkins.arangodb.biz:3456/view/PR/job/arangodb-matrix-pr/18936/

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

Aditya Mukhopadhyay added 30 commits July 29, 2021 15:27
As suggested in #14599.
+fixed minor bug in form field setter
+error div spacing fix.
@adityamukho adityamukho marked this pull request as draft December 20, 2021 13:02
@adityamukho adityamukho added this to the 3.10 milestone Dec 20, 2021
@adityamukho adityamukho added the 3 UI ArangoDB Web Interface (frontend/Aardvark) label Dec 20, 2021
@adityamukho adityamukho changed the title [DRAFT] Views Web UI Views Web UI Dec 30, 2021
@adityamukho adityamukho marked this pull request as ready for review December 30, 2021 05:29
Copy link
Contributor

@ajurdak ajurdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff :-)

# Conflicts:
#	js/apps/system/_admin/aardvark/APP/frontend/js/views/navigationView.js
@cla-bot cla-bot bot added the cla-signed label Jan 10, 2022
@gnusi gnusi merged commit ddbfba9 into devel Jan 10, 2022
@gnusi gnusi deleted the feature/views-web-ui branch January 10, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 ArangoSearch Views 3 UI ArangoDB Web Interface (frontend/Aardvark) cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants