-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views Web UI #15385
Merged
Merged
Views Web UI #15385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in #14599.
+fixed minor bug in form field setter +error div spacing fix.
Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com>
Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com>
…tion menu item. Signed-off-by: Aditya Mukhopadhyay <aditya@arangodb.com>
26 tasks
ajurdak
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff :-)
# Conflicts: # js/apps/system/_admin/aardvark/APP/frontend/js/views/navigationView.js
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is large, since during development of this feature, a lot of UI components that were common to both Analyzers and Views were created/updated. Unfortunately, this led to unavoidable changes to several files in the Analyzers Web UI section, that otherwise have no functional bearing on this feature.
The functionality of the Analyzers UI should remain unaffected, since from the perspective of that section, this PR only introduces functionally invariant code refactors.
Scope & Purpose
This PR enhances the 'Views' section of the AARDVARK UI for ArangoDB, making it feature-complete, i.e. every field/property of an ArangoSearch View can now be configured through forms in the UI, in addition to the already existing method of editing the raw JSON representation. This includes the ability to configure View Links, with full support for their nested/recursive structures. Additionally, the JSON form has been improved with a schema validator, which informs the user of any errors in their JSON input.
Backports:
Related Information
(Please reference tickets / specification / other PRs etc)
Testing & Verification
(Please pick either of the following options)
Link to Jenkins PR run: https://jenkins.arangodb.biz:3456/view/PR/job/arangodb-matrix-pr/18936/
Documentation
External contributors / CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.