Converted rest handler for explain from JS to C++. #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fceller I think the tests are failing for reasons unrelated to the changes now. The tests which fail (RocksDB enterprise build) on Jenkins pass locally. One is due to cluster timeout and the other is because a collection truncate fails (I would guess also related to cluster traffic). Could you let me know if anything looks suspicious and, if not, re-run? |
|
@danielhlarkin agreed |
|
LGTM |
ObiWahn
added a commit
that referenced
this pull request
Aug 3, 2017
…ture/js_to_cpp_transaction_handler * 'devel' of https://github.com/arangodb/arangodb: fixed some issues detected by coverity scan (#2915) remove dependency on MMFiles features from non-MMFiles files (#2925) Converted rest handler for explain from JS to C++. (#2907) added startsBefore() for ApplicationFeature (#2913) Converted a portion of the admin routing API from JS to C++ (#2919) Bug fix/predictable results data modifcation multiple fors (#2921) Feature/cpp aql char length (#2883) slightly move responsibility for recovery (#2922) Feature/issue 387 cluster index estimates (#2866) Converted endpoint handler from JS to C++ (#2905) switch to trusty fixed issue #2876 (#2896) fix a race on shutdown (#2897) fixed issue #2868: cname missing from logger-follow results in rocksdb (#2901) make the V8 feature depend on the authentication feature (#2902) change "parameters" to "bindVars" (#2772) Do not allow replication to create/drop collections (#2898) don't mask errors with fake OOM messages (#2872)
KVS85
added a commit
that referenced
this pull request
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.