Upgrade neutrino and make it extract css to file #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rthor
approved these changes
Mar 15, 2017
|
|
||
| // Add plugin to save extracted css. | ||
| config.plugin('extract-css') | ||
| .use(ExtractTextPlugin, [{ | ||
| filename: '[name].[chunkhash].bundle.css', | ||
| }]) | ||
| } | ||
|
|
||
| // For loaders, the order matters. In this case we want to prepend | ||
| // a loader before existing loaders. |
There was a problem hiding this comment.
Would be good to explain the "why" instead of repeating the function name :) Just for the future :)
NOTE: I, ragnar, am way bad at writing comments, so I'm basically commenting here to remind myself 🤓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.