Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to build with gcc 4.7 #9

Closed
mansoor-s opened this issue Jul 28, 2012 · 0 comments
Closed

Failing to build with gcc 4.7 #9

mansoor-s opened this issue Jul 28, 2012 · 0 comments

Comments

@mansoor-s
Copy link

Hello,

My build failed with the error:

aras-p-glsl-optimizer-f2217b0/tests/glsl_optimizer_tests.cpp:250:22: error: ‘unlink’ was not declared in this scope
make[2]: *** [CMakeFiles/glsl_test.dir/tests/glsl_optimizer_tests.cpp.o] Error 1
make[1]: *** [CMakeFiles/glsl_test.dir/all] Error 2
make: *** [all] Error 2

Fix: add unistd.h to /tests/glsl_optimizer_tests.cpp for non-windows builds

http://gcc.gnu.org/gcc-4.7/porting_to.html

Cheers
@aras-p aras-p closed this as completed in 3fac24a Aug 18, 2012
@behdad behdad mentioned this issue Jan 14, 2014
Open
aras-p pushed a commit that referenced this issue Oct 11, 2014
@ianromanick
glsl: Round struct size up to at least 16 bytes
2ab71e1 
Per rule #9, the size of the structure is vec4 aligned.  The MAX2 in the
loop ensures that sizes >= 16 bytes are vec4 aligned.  The new MAX2
after the loop ensures that sizes < 16 bytes are vec4 aligned.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82932
Cc: mesa-stable@lists.freedesktop.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aras-p @mansoor-s