Various fixes

[mawww]

Hi,

Here are some fixes for the glsl code generator bug I encountered while optimizing our engine glsl code (translated from hlsl with hlsl2glslfork :) ), I did not run the test suite as the test app is not Linux compatible yet, but the results should be changed mainly due to more paranoid parenthesis.

Cheers,

Maxime Coste.

P.S. there looks to be a bug in copy_propagation elements code, I saw
a.xy = a.yx;
a.x = -a.x;
becoming
a.xy = a.yx;
a.x = -a.y;
I'm investigating

[aras-p]

Do you have some shader examples where your changes were needed (parenthesis and the global assignment stuff)? I'd like to add them (or stripped down versions) to the tests.

[mawww]

for the parenthesis:
--- Source ---
uniform float value;
uniform float otherValue;
void main()
{
float invValue = 1.f / value;
float result = otherValue / invValue;
gl_Position = vec4(result);
}
--- Previous result ---
uniform float otherValue;
uniform float value;
void main ()
{
gl_Position = vec4((otherValue / 1.0/(value)));
}
--- New result ---
uniform float otherValue;
uniform float value;
void main ()
{
gl_Position = vec4((otherValue / (1.0/(value))));

}

For the Global:
--- Source ---
uniform float value;
float otherValue = log(value);
void main()
{
gl_Position = vec4(otherValue);
}
--- Previous result ---float otherValue;
uniform float value;
otherValue = log (value);
void main ()
{
gl_Position = vec4(otherValue);
}
--- New result ---
float otherValue;
uniform float value;
//;
void main ()
{
otherValue = log (value);
gl_Position = vec4(otherValue);
}

[aras-p]

Do you have repro shader for the inlining bug with variable names?

[mawww]

mmm, could not reproduce, looks like it's not needed anymore thanks to rename_inlined_variable function.

[aras-p]

Great, now I only need to figure out how to apply only the two commits out of this pull request ;)

[aras-p]

I've applied your parenthesis commit, and then applied the global initializers fix manually (also replaced STL vector; rest of code does not use it so probably not worth dragging STL in...)

Thanks for the patches!

[mawww]

You're welcome, thanks.