various bug fixes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 23, 2012 12:59
The previous approach, which renamed variables in inlining was invalid. nested scope variables were not handled (using a hierarchical visitor would fix that) and loop unrolling too would result on duplicated variables with same name. I encountred same variables names on output even after fixing these two problems, so I guess there is more cases where a variable is duplicated and it's name needs to be changed but is not. This alternative solution, which append a unique id to each variable seems more robust and future proof (should iteract well with future optimization, without needing to check if it duplicates variables).
|
These changes fixed some problems we were running into too, so I agree these should be merged into the main branch. |
|
likewise. |
aras-p
added a commit
that referenced
this pull request
Aug 18, 2012
aras-p
added a commit
that referenced
this pull request
Aug 18, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here are some bug fixes I had to make in order to have glsl optimizer work with our current shader set at Eugen Systems.
Cheers,
Maxime Coste.