Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on faster NMODL. #1840

Merged
merged 17 commits into from Feb 24, 2022

Conversation

thorstenhater
Copy link
Contributor

Half-half dev and user docs on NMODL optimisation. Actually apply that advice in hh.mod

@noraabiakar noraabiakar changed the title Add documentation on faster NMOLD. Add documentation on faster NMODL. Feb 18, 2022
Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this! See other comments. One more: are these tips also applicable to Neuron? Is there any pitfall if the NMODL is going to be used by both simulators?

doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
doc/fileformat/nmodl.rst Show resolved Hide resolved
thorstenhater and others added 6 commits February 18, 2022 14:38
Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com>
Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com>
Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com>
Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com>
Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com>
Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com>
@thorstenhater
Copy link
Contributor Author

Nice to have this! See other comments. One more: are these tips also applicable to Neuron? Is there any pitfall if the NMODL is going to be used by both simulators?

I have no idea what Neuron is doing. So, this is not advice on NRN'NMODL. That said, the BBP NMODL optimiser seems
superficially to be applying the same ideas.

Co-authored-by: Brent Huisman <brenthuisman@users.noreply.github.com>
@brenthuisman
Copy link
Contributor

"Tips for Faster NMODL" could be construed to be generic NMODL optimization advice. Let's add it to the intro then, a tiny remark that this is true for Arbor, and possibly but not necessarily for NRN.

Copy link
Contributor

@noraabiakar noraabiakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I can't think of any other tips at the moment. I just have one small note.

doc/fileformat/nmodl.rst Outdated Show resolved Hide resolved
@noraabiakar noraabiakar self-assigned this Feb 21, 2022
@brenthuisman brenthuisman merged commit 03f5d30 into arbor-sim:master Feb 24, 2022
@thorstenhater thorstenhater deleted the doc/nmodl-speed-guide branch August 1, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants