add cmake checks for non-bundled random123 #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Currently tests building with bundled random123 are failing with
CMake Error in ext/CMakeLists.txt:
Target "ext-random123" INTERFACE_INCLUDE_DIRECTORIES property contains
path:
"/home/runner/work/arbor/arbor/ext/RANDOM123_INCLUDE_DIR-NOTFOUND"
which is prefixed in the source directory.
I don't understand how that incorrect path is generated, but I don't speak CMake very well. Could it be the double install?
ext/CMakeLists.txt
Outdated
| target_include_directories(ext-random123 INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>/random123/include) | ||
| if(ARB_USE_BUNDLED_RANDOM123) | ||
| target_include_directories(ext-random123 INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>/random123/include) | ||
| install(TARGETS ext-random123 EXPORT arbor-targets) |
There was a problem hiding this comment.
This line is present twice, again after endif().
There was a problem hiding this comment.
I tested and fixed the issue when using the system random123, but broke using the bundled Random123. My latest commit should fix the issue.
The double install was a separate bug, well spotted.
Don't worry about not understanding CMake, I don't think anybody really does.
brenthuisman
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Random123 is a proper sub-module, and not simply bundled in tree, ensure that the system version is used when we don't
USE_BUNDLED_LIBS.