Build new releases on merge to master #80
Conversation
|
Had to do some updates after posting, but I believe that it will work when we hit |
|
Maybe you can fork the project and try it first?
On Jan 15, 2019, at 5:21 PM, Christopher Waldon <notifications@github.com<mailto:notifications@github.com>> wrote:
Had to do some updates after posting, but I believe that it will work when we hit merge.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#80 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdlB5yjgFK0q7KyBBqAelJoH9lQjsjOWks5vDlRKgaJpZM4aA72O>.
|
|
Good suggestion. I'm doing that now |
|
Making Windows users download 7zip or another archive utility is very funny to me. I think we should use a file format that the native OS can support without any extra tools. For Windows, I suggest using the classic |
| exit 0 | ||
| fi | ||
|
|
||
| # get hub if we don't have it |
There was a problem hiding this comment.
get hub <-- this hurt my brain to read
| # build pre-release if not on a tag, otherwise build release | ||
| if ! git describe --tags --exact-match HEAD > /dev/null 2>&1 ; then | ||
| echo "Building pre-release, not tagged commit" | ||
| readonly tag="release-$(echo ${head_commit} | head -c 7)" |
There was a problem hiding this comment.
thank you for using readonly
| archive_name="$project-$os.tar.gz" | ||
| echo "Building $project for $os" | ||
| env GOOS="$os" CGO_ENABLED=0 go build -o "$bin_name" &&\ | ||
| tar czf "$archive_name" "$bin_name" &&\ |
There was a problem hiding this comment.
this does mean that you have to install more third-party tools to unpack windows release files. i'm not going to block on this as there are several well-known tools for this and the target audience is sure to know what they are and how to find/install them.
|
@Caton101, I resemble that remark! 😆 |
|
Should we delete this branch to prevent stale branches? |
This pull request should configure TravisCI building and publishing a release each time we update the master branch. I have tested it as well as I know how to in an isolated environment. Unfortunately, the only way to see that works for sure is to merge it.