Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvcc warnings are not caught in testing #272

Open
aprokop opened this issue Apr 17, 2020 · 4 comments · May be fixed by #1108
Open

nvcc warnings are not caught in testing #272

aprokop opened this issue Apr 17, 2020 · 4 comments · May be fixed by #1108
Labels
testing Anything to do with tests and CI

Comments

@aprokop
Copy link
Contributor

aprokop commented Apr 17, 2020

Detected in #268. Warnings like

/var/jenkins/workspace/ArborX_PR-268/src/details/ArborX_Predicates.hpp(34): warning: __device__ annotation is ignored on a function("Nearest") that is explicitly defaulted on its first declaration

were not detected in Style. It seems that there is problematic interaction of nvcc_wrapper, nvcc, jenkins, etc.

@aprokop aprokop added the testing Anything to do with tests and CI label Apr 17, 2020
@masterleinad
Copy link
Collaborator

We should be able to just record the compiler output manually and grep for "warning: ". That's certainly not perfect but should work as a workaround.

@aprokop
Copy link
Contributor Author

aprokop commented Apr 17, 2020

I think a better solution would be to make Style check pick it up. The following pattern works to transform nvcc style warnings to that of gcc:

sed "s/\(.*\)(\([[:digit:]]*\)):/\1:\2:/"'

Just need to make the output transform to that in .jenkins. Quick hack did not work for me, though.

@aprokop
Copy link
Contributor Author

aprokop commented May 8, 2024

We should introduce -Werror to CUDA builds.

@aprokop
Copy link
Contributor Author

aprokop commented Jun 6, 2024

Should do it after kokkos/kokkos#7021 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything to do with tests and CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants