Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in access_traits_host example #313

Closed
aprokop opened this issue May 21, 2020 · 3 comments · Fixed by #351
Closed

Fix warning in access_traits_host example #313

aprokop opened this issue May 21, 2020 · 3 comments · Fixed by #351
Labels
build Build and installation

Comments

@aprokop
Copy link
Contributor

aprokop commented May 21, 2020

../examples/access_traits/example_host_access_traits.cpp(48): here

../src/details/ArborX_DetailsTreeConstruction.hpp(240): warning: calling a __host__ function("std::vector< ::ArborX::Point, ::std::allocator< ::ArborX::Point> > ::vector") from a __host__ __device__ function("") is not allowed

We never see them in CI due to #272. I'm not sure what's the best to fix it. Probably move away from using std::vector. Removing KOKKOS_FUNCTION would not work as Access::get is called from such a function.

@aprokop aprokop added the build Build and installation label May 21, 2020
@dalg24
Copy link
Contributor

dalg24 commented May 22, 2020

Well either we remove that example when CUDA is enabled or we keep on looking the other way.

@aprokop
Copy link
Contributor Author

aprokop commented May 22, 2020

What is the thinking behind using std::vector in the example? With that, one is only able to construct the hierarchy, but not even query it as we need Kokkos::View for that.

@dalg24
Copy link
Contributor

dalg24 commented May 22, 2020

What is the thinking behind using std::vector in the example?

The motivation was to provide another example of access traits that does not require CUDA.

With that, one is only able to construct the hierarchy, but not even query it as we need Kokkos::View for that.

You need views for {offset, indices}, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build and installation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants