-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kokkos 3.1 #268
Kokkos 3.1 #268
Conversation
What is the rationale for having this in addition to #236? |
Introducing HIP backend and fixing corresponding issues is separate from moving ArborX to Kokkos 3.1. |
I am happy if you cherry-pick all the other changes from that branch that are not related to |
Retest this please. |
I don't understand why it passes. If I look at, say, CUDA-10.1-NVCC build, I see
in the output. But Style check still passes. |
I would not be surprised if it doesn't catch warnings coming from the device compiler. |
Can you please fix those? |
We still have
but I would just not care about the |
Thanks. I noticed that too. In CUDA build the thing that produces the error
For some reason I don't see any |
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Rebased on top of master. Temporarily removed defaulted function patch to see the reaction of CI on it. |
Interestingly, even when you have warnings, they are not being caught by
So, it is likely |
The warning flags Suppressing nvcc warnings is really hard most of the times (if it is not explicitly mentioned in the As a side-note: |
it seems that jenkins warnings plugin does not support nvcc. |
retest this please |
64df4be
to
744950f
Compare
OK, please don't breathe on this PR, the checks passed :) |
I did but you forced push over it... |
@dalg24 I apologize, really should not have done it. Did not realize you were working on it too. |
@dalg24 Can you please approve and merge once the tests pass? |
The main motivation for updating to 3.1 it to allow HIP backend. We could have done magic to still work with 3.0, but we decided not to bear cost of supporting that.