-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization for moving least squares #1000
Optimization for moving least squares #1000
Conversation
@mrlag31 Can you please explain in more details what the difference is? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by comments
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsMovingLeastSquaresCoefficients.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about renaming in symmetricPseudoInverseSVDKernel
. I don't think the new names make it any clearer, and would prefer the old names.
I felt like the old ones were harder to understand. The new ones directly explains, by their name, what they are in regards to the formula, whereas the old ones were a bit too abstract. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the current state.
This PR modifies the SVD pseudo-inverse and the coefficients computation, its main goal was to reduce the amount of global memory used, use scratch memory and compound the kernels.