[WIP] Avoid Alltoall in createFromSends #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please. |
1 similar comment
|
Retest this please. |
|
Just a general comment. If this approach works better than the original, I think it should be encapsulated in some helper function instead of sticking it into the place it is called from. |
masterleinad
force-pushed
the
avoid_all_to_all
branch
from
ac905ab
to
e445cdb
Compare
masterleinad
force-pushed
the
avoid_all_to_all
branch
from
e445cdb
to
3b4b0a8
Compare
|
What do we do with this one? Is it OK to close it for now, and reopen when the need arises? |
We can close it if it's bothering anyone having it around. |
masterleinad
changed the title
|
No activity, no progress, and no path forward. Closing. Resurrect if effort is allocated, or a need arises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a large number of processes, it should be better to avoid
MPI_Alltoalland compute the number of messages to receive instead and then just perform necessary point-to-point communication.I still need to measure if there is an impact on larger runs.