Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DBSCAN post-processing to avoid calling sort #453

Merged
merged 9 commits into from
Jan 12, 2021
Merged

Update DBSCAN post-processing to avoid calling sort #453

merged 9 commits into from
Jan 12, 2021

Commits on Jan 12, 2021

  1. Update DBSCAN post-processing to avoid calling sort 

    We know that Kokkos::BinSort struggles on arrays with duplicated
indices, which is certainly the case here, as the sort is called on
cluster indices.

The new approach completely avoids that. And, in fact, seems to be
faster.
    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    7c31eb6 View commit details
    Browse the repository at this point in the history

  2. Use heap to order cluster indices for reproducibility

    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    c65dfa8 View commit details
    Browse the repository at this point in the history

  3. Fix a bug in DBSCAN verification routine 

    The passed `clusters` view was unintentionally modified during
verification, causing issues for post-processing when verify was
enabled. This problem has been around for a long time, and was uncovered
before because the output results were never checked when run with
verify.
    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    4617d0b View commit details
    Browse the repository at this point in the history

  4. Silence clang-tidy warnings

    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    02a86a9 View commit details
    Browse the repository at this point in the history

  5. Introduce heapSort

    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    1d7b0b1 View commit details
    Browse the repository at this point in the history

  6. Switch to using heapSort in DBSCAN center calculations

    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    5e2154f View commit details
    Browse the repository at this point in the history

  7. Added a comment requested in the review

    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    8dbcf73 View commit details
    Browse the repository at this point in the history

  8. Add makeHeap

    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    7c6845f View commit details
    Browse the repository at this point in the history

  9. Get rid of heapSort, because it's not in the C++ stl standard

    @aprokop
    aprokop committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    929c1c9 View commit details
    Browse the repository at this point in the history