-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo #56
Logo #56
Conversation
Can one of the admins verify this patch? |
ok to test |
Making sure the logo does not break the code? |
You never know.:wink: |
Thanks, @anagainaru, great work! I actually like it a lot! My preference would be:
In general, there is also a bit of concern about having a vectorized image for scaling, but I guess if we had a very high density raster image, that could also work. |
yeah, better make sure that the logo does not wreck havoc 🤦♂ |
Without the bottom tree nobody will understand what the roots are, but agree that it needs to be more discreet. I'll rethink the tree.
I'll see how many elements can be included before it becomes too crowded, but I like the enthusiasm :)
The final version will be vectorized (not latex, but you are welcome to find a way to convert it from corelDRAW to whatever you like)
Security first, good to see my taxes are not wasted |
The electronic components look nicer in the second one, but honestly, I like the first one a lot better. And maybe emphasizing X was a stupid idea on my part :| |
Good I agree, I like the first one more also :) I can put the electronic from the second on the first one |
Like the upper part, but still have the same comments about the bottom part. I'm going to step back now and allow others to comment on the design. |
@aprokop So you want the logo to be an upside down tree without the tree? If I remove the bottom part, the logo will look like an electrocuted squid :) The bottom part is smaller so the logo is less vertical now and should fit on the github square space. I think you guys should either keep the tree or throw away both the top and bottom (and ask for something else) |
I also prefer something like that to |
I like v1.1. @aprokop to me your version looks like a bush not the root of tree. |
So far I like v1.1 best. I find the large suggestion pretty hard to understand. |
Lets resurrect this and just decide on one. |
Do you have a new opinion? |
Two of you liked v1.1, I'm OK with it, @dalg24 never told us anything. So lets just go with it. Probably just need a scalable .svg version of it, or multiple raster sizes. |
@dalg24 Do you have an opinion? |
|
Cool. If all agree on 1.1, what's the next step for this? @anagainaru to provide the raw files? Of note, I tried changing the ArborX organization's logo to v1.1, but it does not work well because it requires a square (and the width is fixed to that of the image). |
@anagainaru Great! Thanks a lot! All, I set th organization profile picture to the latest one. |
May also want a transparent variant for profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NO MERGING WITHOUT MY APPROVING HISTORY
@dalg24 See, you can learn. |
Are you referring to the logo already being visible? |
Not sure I understand. |
I think the only remaining thing here is to have the SVG versions. I tried making them myself from the png files of this PR, but was not super successful. I used Inkscape, The result is attached (renamed from svg to txt) It does not follow curves well. @anagainaru thank you once again for your work. In one of your previous comments you wrote
Were you thinking of a different approach? |
I was planing on using CorelDraw to generate the SVG file. It's not an automatic process so I need to dedicate some time to it. Ask me again Monday if I don't upload it. |
@anagainaru Thank you. I don't want to waste your time. I think it would be sufficient if you could briefly write about how it could be done. |
Finished the SVG version, since it's a bit different than the original one (it's impossible to get exactly the same), I'm uploading both the SVG and the corresponding PNG. Take a look and make sure everything looks good. |
@anagainaru This looks great! Thank you so much. Lets merge it after doing the following:
@anagainaru I can take care of this if you are OK with it. |
Sure @aprokop let me know if you need help removing the bg |
a0567dc
to
c54b682
Compare
Alright, this should be ready for merge. |
For the record: to produce transparent background, I used GIMP:
|
This is a first draft. I need to get a better understanding of what is needed from the logo to continue.
Focus on big picture feedback (width to height ratio, text in the middle of the tree (font, size, position), upside down tree, etc) and not on details. Details can be changed later once we set the main features.