Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo #56

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Logo #56

merged 4 commits into from
Apr 1, 2020

Conversation

anagainaru
Copy link
Contributor

This is a first draft. I need to get a better understanding of what is needed from the logo to continue.

Focus on big picture feedback (width to height ratio, text in the middle of the tree (font, size, position), upside down tree, etc) and not on details. Details can be changed later once we set the main features.

@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@aprokop
Copy link
Contributor

aprokop commented May 10, 2019

ok to test

@dalg24
Copy link
Contributor

dalg24 commented May 10, 2019

ok to test

Making sure the logo does not break the code?

@masterleinad
Copy link
Collaborator

Making sure the logo does not break the code?

You never know.:wink:

@aprokop
Copy link
Contributor

aprokop commented May 10, 2019

Thanks, @anagainaru, great work! I actually like it a lot! My preference would be:

  • get rid of the bottom tree
    But maybe leave its "grass" so that ArborX title is adorned from both top and bottom
  • make the remainder closer to square shape
    Does not have to be square, though
  • make the electronic-like components not extend outside of the rectangular box posed by the tree
    This may require removing one of the branches
  • Maybe do something special about the X letter
    There is a very nice symmetry in the font between starting A and final R letters, would be nice to somehow emphasize that
  • Maybe do something interesting with the end points of circuits?
    Maybe organize them in some parallel structure?
  • There is a whole question of the tree.
    It looks a bit spooky to me 😄 But I do like that it's almost contained in half-circle (maybe make it strictly contained there?)

In general, there is also a bit of concern about having a vectorized image for scaling, but I guess if we had a very high density raster image, that could also work.

@aprokop
Copy link
Contributor

aprokop commented May 10, 2019

Making sure the logo does not break the code?

yeah, better make sure that the logo does not wreck havoc 🤦‍♂

@anagainaru
Copy link
Contributor Author

  • get rid of the bottom tree
    But maybe leave its "grass" so that ArborX title is adorned from both top and bottom

Without the bottom tree nobody will understand what the roots are, but agree that it needs to be more discreet. I'll rethink the tree.

  • make the electronic-like components not extend outside of the rectangular box posed by the tree
    This may require removing one of the branches
  • Maybe do something special about the X letter
    There is a very nice symmetry in the font between starting A and final R letters, would be nice to somehow emphasize that
  • Maybe do something interesting with the end points of circuits?
    Maybe organize them in some parallel structure?

I'll see how many elements can be included before it becomes too crowded, but I like the enthusiasm :)

In general, there is also a bit of concern about having a vectorized image for scaling, but I guess if we had a very high density raster image, that could also work.

The final version will be vectorized (not latex, but you are welcome to find a way to convert it from corelDRAW to whatever you like)

yeah, better make sure that the logo does not wreck havoc

Security first, good to see my taxes are not wasted

@aprokop aprokop added this to the 2019 May release milestone May 10, 2019
@aprokop
Copy link
Contributor

aprokop commented May 13, 2019

The electronic components look nicer in the second one, but honestly, I like the first one a lot better. And maybe emphasizing X was a stupid idea on my part :|

@anagainaru
Copy link
Contributor Author

The electronic components look nicer in the second one, but honestly, I like the first one a lot better. And maybe emphasizing X was a stupid idea on my part :|

Good I agree, I like the first one more also :) I can put the electronic from the second on the first one

@aprokop
Copy link
Contributor

aprokop commented May 14, 2019

Like the upper part, but still have the same comments about the bottom part. I'm going to step back now and allow others to comment on the design.

@anagainaru
Copy link
Contributor Author

@aprokop So you want the logo to be an upside down tree without the tree? If I remove the bottom part, the logo will look like an electrocuted squid :)

The bottom part is smaller so the logo is less vertical now and should fit on the github square space. I think you guys should either keep the tree or throw away both the top and bottom (and ask for something else)

@aprokop
Copy link
Contributor

aprokop commented May 14, 2019

If I remove the bottom part, the logo will look like an electrocuted squid :)

Beauty in the eye of beholder ;)

I personally lean towards something like this:
Screen Shot 2019-05-14 at 5 52 03 PM

@masterleinad
Copy link
Collaborator

I personally lean towards something like this:

I also prefer something like that to logo_v2.0.jpg but at least parts of the trunk should be visible.

@Rombur
Copy link
Collaborator

Rombur commented May 15, 2019

I like v1.1. @aprokop to me your version looks like a bush not the root of tree.

@anagainaru
Copy link
Contributor Author

When the logo is smaller it's even harder to understand what the roots are. With v1.1 you at least get the idea even if you don't see details.

arborx_github2

arborx_github

@aprokop
Copy link
Contributor

aprokop commented Jun 1, 2019

@dalg24 @Rombur Please weigh in with your opinions.

@anagainaru
Copy link
Contributor Author

If you really don't want the tree, I'd prefer removing all traces of it (and just leave circuits). Something like this:

arborx_v3 0

@masterleinad
Copy link
Collaborator

So far I like v1.1 best. I find the large suggestion pretty hard to understand.

@aprokop
Copy link
Contributor

aprokop commented Oct 4, 2019

Lets resurrect this and just decide on one.

@masterleinad
Copy link
Collaborator

Do you have a new opinion?

@aprokop
Copy link
Contributor

aprokop commented Oct 4, 2019

Two of you liked v1.1, I'm OK with it, @dalg24 never told us anything. So lets just go with it. Probably just need a scalable .svg version of it, or multiple raster sizes.

@aprokop
Copy link
Contributor

aprokop commented Oct 9, 2019

@dalg24 Do you have an opinion?

@dalg24
Copy link
Contributor

dalg24 commented Oct 9, 2019

_v1_1 works with me

@aprokop
Copy link
Contributor

aprokop commented Oct 9, 2019

Cool. If all agree on 1.1, what's the next step for this? @anagainaru to provide the raw files?

Of note, I tried changing the ArborX organization's logo to v1.1, but it does not work well because it requires a square (and the width is fixed to that of the image).

@anagainaru
Copy link
Contributor Author

logo_v1_1

This is the _v1_1 I have on my laptop, which has padding to be square, it should be fine for the organization logo. Is this the one you want? I can vectorize it this weekend.

@aprokop
Copy link
Contributor

aprokop commented Oct 9, 2019

@anagainaru Great! Thanks a lot!

All, I set th organization profile picture to the latest one. The funny thing, in your personal profile you will see it (the tree), however when you go to the organization page, it still shoes the regular github one. Not sure what's going on. Nevermind, it just got updated.

@aprokop
Copy link
Contributor

aprokop commented Oct 9, 2019

May also want a transparent variant for profile.

dalg24
dalg24 previously requested changes Oct 9, 2019
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO MERGING WITHOUT MY APPROVING HISTORY

@aprokop
Copy link
Contributor

aprokop commented Oct 9, 2019

@dalg24 See, you can learn.

@masterleinad
Copy link
Collaborator

@dalg24 See, you can learn.

Are you referring to the logo already being visible?

@aprokop
Copy link
Contributor

aprokop commented Oct 9, 2019

Are you referring to the logo already being visible?

Not sure I understand.

@aprokop aprokop removed this from the Release 1.0 milestone Oct 18, 2019
@aprokop
Copy link
Contributor

aprokop commented Mar 27, 2020

I think the only remaining thing here is to have the SVG versions. I tried making them myself from the png files of this PR, but was not super successful. I used Inkscape, Path->Trace bitmap with the following settings

settings1
settings2

The result is attached (renamed from svg to txt)
logo_v1_1_nobg.txt

It does not follow curves well. @anagainaru thank you once again for your work. In one of your previous comments you wrote

I can vectorize it this weekend.

Were you thinking of a different approach?

@anagainaru
Copy link
Contributor Author

I was planing on using CorelDraw to generate the SVG file. It's not an automatic process so I need to dedicate some time to it. Ask me again Monday if I don't upload it.

@aprokop
Copy link
Contributor

aprokop commented Mar 27, 2020

@anagainaru Thank you. I don't want to waste your time. I think it would be sufficient if you could briefly write about how it could be done.

@anagainaru
Copy link
Contributor Author

Finished the SVG version, since it's a bit different than the original one (it's impossible to get exactly the same), I'm uploading both the SVG and the corresponding PNG. Take a look and make sure everything looks good.

@aprokop
Copy link
Contributor

aprokop commented Mar 31, 2020

@anagainaru This looks great! Thank you so much.

Lets merge it after doing the following:

  • remove v1.1 versions
  • add 1.2_nobg version
  • rebase on top of current master
  • move logos to docs/logos
  • update README.md to use the logo
  • (optional) squash the original commits

@anagainaru I can take care of this if you are OK with it.

@anagainaru
Copy link
Contributor Author

@anagainaru I can take care of this if you are OK with it.

Sure

@aprokop let me know if you need help removing the bg

@aprokop aprokop force-pushed the logo branch 3 times, most recently from a0567dc to c54b682 Compare March 31, 2020 19:37
@aprokop
Copy link
Contributor

aprokop commented Mar 31, 2020

Alright, this should be ready for merge.

@aprokop
Copy link
Contributor

aprokop commented Mar 31, 2020

For the record: to produce transparent background, I used GIMP:

  • Layer->Transparency->Add Alpha Channel
  • Edit->Transparency->Color To Alpha

@aprokop aprokop added this to the Release 1.0 milestone Apr 1, 2020
@aprokop aprokop dismissed dalg24’s stale review April 1, 2020 13:43

ignore this dude

@aprokop aprokop merged commit 8708e30 into arborx:master Apr 1, 2020
@anagainaru anagainaru deleted the logo branch May 19, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants