Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ropes for all backends #672

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Use ropes for all backends #672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb97099
Also use ropes for SYCL
masterleinad Apr 11, 2022
d548de3
perf-test: Always use ropes
masterleinad Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/ArborX_LinearBVH.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,22 +84,7 @@ class BasicBoundingVolumeHierarchy
private:
friend struct Details::HappyTreeFriends;

#if defined(KOKKOS_ENABLE_CUDA) || defined(KOKKOS_ENABLE_HIP)
// Ropes based traversal is only used for CUDA, as it was found to be slower
// than regular one for Power9 on Summit. It is also used with HIP.
using node_type = std::conditional_t<
std::is_same<MemorySpace,
#if defined(KOKKOS_ENABLE_CUDA)
Kokkos::CudaSpace
#else
Kokkos::Experimental::HIPSpace
#endif
>{},
Details::NodeWithLeftChildAndRope<bounding_volume_type>,
Details::NodeWithTwoChildren<bounding_volume_type>>;
#else
using node_type = Details::NodeWithTwoChildren<bounding_volume_type>;
#endif
using node_type = Details::NodeWithLeftChildAndRope<bounding_volume_type>;

Kokkos::View<node_type *, MemorySpace> getInternalNodes()
{
Expand Down