Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node with two children in favor of node with left child and rope #690

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Remove node with two children in favor of node with left child and rope #690

merged 1 commit into from
Jun 21, 2022

Conversation

dalg24
Copy link
Contributor

@dalg24 dalg24 commented Jun 20, 2022

Following up on #672 (review)
Cleaning up and removing Details::NodeWithTwoChildren

@dalg24 dalg24 added the refactoring Code reorganization label Jun 20, 2022
masterleinad
masterleinad approved these changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think it's fine to get rid of the tags altogether. If we want to try something else again, it shouldn't be too hard to come back.

@dalg24
Copy link
Contributor Author

dalg24 commented Jun 20, 2022

CUDA-11.0.3-Clang is hanging. Not sure if it is worth re-running.

@aprokop aprokop merged commit 85d854d into arborx:master Jun 21, 2022
@dalg24 dalg24 deleted the remove_node_with_two_children branch June 21, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@aprokop aprokop aprokop approved these changes

Assignees
No one assigned
Labels
refactoring Code reorganization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalg24 @masterleinad @aprokop