Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add union-find benchmark #781

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Nov 9, 2022

This would allow to evaluate any changes in the union-find data structure.

@aprokop
Copy link
Contributor Author

aprokop commented Dec 2, 2022

Please review.

benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a dependency in Boost.ProgramOptions and not in a Google benchmark?

benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
@aprokop
Copy link
Contributor Author

aprokop commented Dec 8, 2022

@dalg24

Why a dependency in Boost.ProgramOptions and not in a Google benchmark?

I think the dependency on boost.program_options is required because I want to allow running the benchmark with different problem sizes, which would depend on the backend.

@dalg24
Copy link
Contributor

dalg24 commented Dec 8, 2022

If we are worried about minimal dependency we can parse the command line arguments ourselves. I find it a little surprising (the not using Google benchmark).

@aprokop
Copy link
Contributor Author

aprokop commented Dec 8, 2022

If we are worried about minimal dependency we can parse the command line arguments ourselves. I find it a little surprising (the not using Google benchmark).

Setting Benchmark seems a bit heavy. We only have a single benchmark currently using it (bvh_driver). It is doable, though.

}
bool allow_loops = !disallow_loops;

printf("allow loops : %s\n", (allow_loops ? "yes" : "no"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still finds this confusing because if I set the parameter to true, we output no on the screen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My perspective is that the default behavior without specifying the flag should be allowing the loops. Then, the boolean switch would be used to prohibit the loops. It is unclear to me how would one use a boolean switch in this context.

@aprokop
Copy link
Contributor Author

aprokop commented Dec 28, 2022

Rebased on master to include #799.

benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
benchmarks/union_find/union_find.cpp Outdated Show resolved Hide resolved
@dalg24 dalg24 merged commit ffaa83f into arborx:master Jan 5, 2023
@aprokop aprokop deleted the pr_benchmark_union_find branch January 5, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants