Require benchmark 1.5.4, update nightly containers to Ubuntu 22.04

[aprokop]

• Require benchmark 1.5.4
• Update our BVH benchmark to use new rate feature
• Update nightly containers to Ubuntu 22.04

Still no way to require specific version of the benchmark in CMake, though. The main reason for the PR is to not propagate this rate issue to other benchmarks, such as union-find.

[dalg24]

not propagate this rate issue to other benchmarks, such as union-find.

I do not follow. What do you mean?

[aprokop]

I do not follow. What do you mean?

In the bvh_driver we had a comment about how we would have used a kIsIterationInvariantRate feature but it's only available in 1.5. I would have added a similar FIXME to the union-find benchmark. It's not a big deal, but also a debt.

[dalg24]

v1.5.0 was released in May 2019 (vs May 2018 for v1.4.1)
One thing to check is whether that would break our nightly builds because they install libbenchmark-dev using the system package manager. Both builds are Ubuntu20.04-based but we could upgrade to Ubuntu22.04 images as needed.

Another thing to consider is whether to adopt a more recent version that has the package version set. For the record, support was added in google/benchmark#1047

[aprokop]

One thing to check is whether that would break our nightly builds because they install libbenchmark-dev using the system package manager. Both builds are Ubuntu20.04-based but we could upgrade to Ubuntu22.04 images as needed.

Yes, it will break the builds. Ubuntu20.04 comes with benchmark 1.5.0.

Another thing to consider is whether to adopt a more recent version that has the package version set. For the record, support was added in google/benchmark#1047

I think it's a good idea. The first version of the benchmark that includes that PR is 1.5.4.

[dalg24]

Why 11.7.1?
For the record, looking at docker hub https://hub.docker.com/r/nvidia/cuda/tags?page=1&name=ubuntu22, we can chose from [11.7.0, 11.7.1, 11.8.0, 12.0.0]

[aprokop]

Well, out of those versions, I wanted the earlierst, but thought that maybe 11.7.1 fixed some bugs in 11.7.0.

[dalg24]

Sure. For the record we have to chose from [5.3, 5.4]

[dalg24]

Make sure you update the wiki

[aprokop]

Was accidentally closed by 803.

[dalg24]

Maybe copy/paste the nightly builds into the continuous to check that it actually works

[aprokop]

Apparently apt is broken in the new CUDA images used for nightly. apt-get update fails with

W: GPG error: http://archive.ubuntu.com/ubuntu jammy-updates InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 871920D1991BC93C

[aprokop]

Maybe copy/paste the nightly builds into the continuous to check that it actually works

Yeah, was trying to update the wiki to see what versions it carries, and ran into issues.

[Rombur]

Yes, I have seen this before https://stackoverflow.com/questions/71941032/why-i-cannot-run-apt-update-inside-a-fresh-ubuntu22-04 We need to update docker to use a ubuntu 22.04 image

[aprokop]

Yes, I have seen this before stackoverflow.com/questions/71941032/why-i-cannot-run-apt-update-inside-a-fresh-ubuntu22-04 We need to update docker to use a ubuntu 22.04 image

The error I'm getting is different, though, and related to the keys. On my workstation, I'm running docker 18.09.6 🤷‍♂️

[aprokop]

Apparently apt is broken in the new CUDA images used for nightly. apt-get update fails with

Nevermind. Apparently, it's only broken on my machine. The nightly builds pass just fine: https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/ArborX/detail/PR-799/5/pipeline.

@dalg24 No issues.