Add HDBSCAN #783
Merged
Add HDBSCAN #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
added
enhancement
dalg24
reviewed
Nov 12, 2022
Comment on lines
+33
to
+34
| Kokkos::Profiling::ProfilingSection profile_mst("ArborX::HDBSCAN::mst"); | ||
| profile_mst.start(); |
There was a problem hiding this comment.
Why are the regions "ArborX::HDBSCAN" with the nested "ArborX::MST::MST" and "ArborX::Dendrogram::Dendrogram" not sufficient?
There was a problem hiding this comment.
These are profiling sections that we'll use to print out the timers. When using Kokkos tooling like space-time-stack, those would have been sufficient.
aprokop
force-pushed
the
hdbscan_cleanup
branch
from
8c2e7d0
to
b303604
Compare
dalg24
reviewed
Nov 12, 2022
dalg24
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains first two parts, but does not contain flat clustering right now.