Merge pull request #49 from ziggycrane/security_updates

Fix #44: XSS bugs and according improvements
arbory · May 15, 2018 · 5d8a861 · 5d8a861
2 parents 8b131b4 + a5a08c1
commit 5d8a861
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/Admin/Form/Fields/Slug.php b/src/Admin/Form/Fields/Slug.php
@@ -92,19 +92,15 @@ protected function getLinkElement()
      */
     protected function getLinkValue()
     {
-        $urlToSlug = $this->getUriToSlug();
-        $urlToSlugElement = Html::span( $this->getUriToSlug() );
-
-        if( $urlToSlug )
-        {
-            $urlToSlugElement .= '/';
-        }
+        $urlToSlug = ltrim($this->getUriToSlug(), "/");
+        $urlToSlugElement = Html::span( $urlToSlug );
 
         return [
             [
                 url( '/' ),
                 '/',
                 $urlToSlugElement,
+                ( $urlToSlug ) ? '/' : ''
             ],
             Html::span( $this->getValue() )
         ];

diff --git a/src/Admin/Grid/Builder.php b/src/Admin/Grid/Builder.php
@@ -79,7 +79,7 @@ protected function getTableColumns()
             return $this->getColumnHeader( $column );
         } );
 
-        $tableColumns->push( Html::th( Html::span( '&nbsp;' ) ) );
+        $tableColumns->push( Html::th( Html::span( ' ' ) ) );
 
         return $tableColumns;
     }