Redirect healthcheck #156
Redirect healthcheck #156
Conversation
polinart
commented
Jul 23, 2019
polinart
commented
- added 'status' field in 'redirects' table
- added job to check redirects and update 'status' field
- added console command to check few table record or all records and update status
- added observer to handle 'saved' event: check url and update status
…ommand to check all redirect entries;
…P_USER and APP_PASSWORD;
Change invalid and valid fields key => value to update status for duplicated url values;
composer.json
Outdated
| @@ -32,7 +32,8 @@ | |||
| "roboc/laravel-glide": "^1.1.0", | |||
| "spatie/laravel-sluggable": "^2.1.0", | |||
| "maatwebsite/excel": "^3.0.5", | |||
| "unisharp/laravel-filemanager": "^1.8.5" | |||
| "unisharp/laravel-filemanager": "^1.8.5", | |||
| "ext-curl": "*" | |||
There was a problem hiding this comment.
Please move this up, group with other extensions
| */ | ||
| protected $signature = 'arbory.redirect-health | ||
| {ids=[] : The array of IDs from redirects table to check (if not provided then would be selected all redirects table entries)} | ||
| {--errors : Show curl request errors}'; |
There was a problem hiding this comment.
-v --verbose are standart flags to increase console output. Could we use those?
| * @var string | ||
| */ | ||
| protected $signature = 'arbory.redirect-health | ||
| {ids=[] : The array of IDs from redirects table to check (if not provided then would be selected all redirects table entries)} |
There was a problem hiding this comment.
How do we pass "array" via CLI? Please specify that command expects comma separated values.
There was a problem hiding this comment.
Is this really necessary? Who would ever know ID for specific redirect entry.
| */ | ||
| public function handle() | ||
| { | ||
| try { |
There was a problem hiding this comment.
Don't put all your code in Try block, this is bad error suppression
| $result = $job->getResult(); | ||
|
|
||
| if (! empty($result) && count($result->getInvalidUrlList())) { | ||
| $this->warn("\nInvalid URLs list:"); |
There was a problem hiding this comment.
Use PHP_EOL for new line
| $this->error('Redirects healthcheck failed with an exception'); | ||
| $this->error($e->getMessage()); | ||
|
|
||
| return 2; |
| } | ||
|
|
||
| $this->warn("\nInvalid entries: {$result->getInvalidCount()}"); | ||
| $this->info("Valid entries: {$result->getValidCount()}"); |
There was a problem hiding this comment.
Use sprintf or concat for string concatination
|
This pull-requests still has multiple issues and was voted - unnecessary for core Arbory. Closing for now. |
