Bugfix of LFM response structure: case of unsuccessful upload #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboc
reviewed
Jul 31, 2018
| { | ||
| $response = parent::upload(); | ||
|
|
||
| return count($this->errors) > 0 ? $this->errorResponse() : $response; |
There was a problem hiding this comment.
Does this really work?
$this->errors is never populated
There was a problem hiding this comment.
It is in unisharp/laravel-filemanager versions below 2.0
| protected function errorResponse() | ||
| { | ||
| $responseType = request()->input('responseType'); | ||
| if ($responseType && $responseType == 'json') { |
There was a problem hiding this comment.
request('responseType') === 'json' would be simpler
rerzy
pushed a commit
to rerzy/arbory
that referenced
this pull request
Mar 7, 2019
Bugfix of LFM response structure: case of unsuccessful upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKEditor expects error response of following structure:
[ 'uploaded': 0, 'error': [ 'message': someText ] ]But LVM is sending just an array of error messages:
[msg1, msg2, ...]This PR overrides LFM UploadController to correct that behaviour.