Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error after submitting previously cleared ArboryFile file input #89

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

holystix
Copy link
Contributor

@holystix holystix commented Oct 23, 2018

Fixes error where a resource.content.file.remove=1 parameter is needlessly submitted. Error occurs in the following scenario:

  1. A file is added and successfully submitted to an ArboryFile form field input.
  2. File input is cleared (using X button) without submitting the form or reloading the page.
  3. A new file is added to the file input.
  4. Form is submitted.

@holystix holystix changed the title unset ArboryFile remove indicator if input changed Fix error after submitting previously cleared ArboryFile file input Oct 23, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 2.151% when pulling e83905a on holystix:arbory_file_remove_and_add_fix into a1b7b3d on arbory:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 2.151% when pulling e83905a on holystix:arbory_file_remove_and_add_fix into a1b7b3d on arbory:master.

@strads10 strads10 merged commit 955331f into arbory:master Oct 23, 2018
rerzy pushed a commit to rerzy/arbory that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants