Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AdminModuleAccess middeware to all admin routes #98

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Add AdminModuleAccess middeware to all admin routes #98

merged 1 commit into from
Dec 28, 2018

Conversation

exabyssus
Copy link
Contributor

@exabyssus exabyssus commented Dec 28, 2018 •
edited
Loading

When Role don't have permission for custom module, it is removed from menu, but is still accessible unless Middleware is added.

@exabyssus exabyssus added the bug label Dec 28, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 2.151% when pulling f0cb454 on fix_module_access into fc3ed64 on master.

@strads10 strads10 merged commit 8910e13 into master Dec 28, 2018
@exabyssus exabyssus deleted the fix_module_access branch February 13, 2019 13:29
rerzy pushed a commit to rerzy/arbory that referenced this pull request May 17, 2019
@strads10
Merge pull request arbory#98 from arbory/fix_module_access
b13a308 
Add AdminModuleAccess middeware to all admin routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exabyssus @coveralls @strads10