Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev setup docs #265

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Improve dev setup docs #265

merged 4 commits into from
Jun 15, 2023

Conversation

tardigrde
Copy link
Contributor

I wanted to play around with the code, but it was a bit struggle for me, so I'd like to contribute my findings.

As wrote in discord, I had a problem on a debian fresh install with pip install -r application/requirements.txt, I get error:

subprocess.CalledProcessError: Command '['./build_bundled.sh', '0.1.97']' returned non-zero exit status 127.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for sentencepiece
  Running setup.py clean for sentencepiece

When I remove the sentencepiece specific version (==0.1.97), pip figures it out and can install all packages without an issue. Is there a reason you have hardcoded version numbers? I did not change this tho. But I'm interested why do I have this problem

tiktoken and celery were also missing for running wsgi.py. I added them to requirements, but without a hardcoded version. Should I add some static versions?

npx was needed for the husky hook. and I figured out Node v14 is not enough for that.

Add needed packages in for dev setup in requirements.txt
Husky won't run with Node v14
@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 4:52pm

@dartpain
Copy link
Contributor

Fixed container build.

Thank you so much!

in terms of sentencepiece i also pushed a change

@dartpain dartpain merged commit 7e92ed4 into arc53:main Jun 15, 2023
1 check passed
@tardigrde
Copy link
Contributor Author

Thanks Alex!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants