Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhanced]: Useful Links Section in README.md #437

Merged
merged 8 commits into from
Oct 9, 2023
Merged

[Enhanced]: Useful Links Section in README.md #437

merged 8 commits into from
Oct 9, 2023

Conversation

shelar1423
Copy link
Collaborator

Instead of plain texts , i have added icons to make the section look better.

Before:
image

After :
image

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 3:34pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 3:34pm

@shelar1423
Copy link
Collaborator Author

@dartpain let me know the changes required

@shelar1423
Copy link
Collaborator Author

Any updates @dartpain

@dartpain
Copy link
Contributor

dartpain commented Oct 6, 2023

Hi, great idea I really appreciate it. Just one comment:
Icon for discord is great, can you maybe look for icons that are more modern/ fit our style more please.

Thank you!

@shelar1423
Copy link
Collaborator Author

shelar1423 commented Oct 6, 2023

@dartpain all of those except discord right ?

@dartpain
Copy link
Contributor

dartpain commented Oct 6, 2023

Yep exactly, thank you. Maybe check out mui icons or something like that, maybe @tenokami can help you too

@shelar1423
Copy link
Collaborator Author

Sure, @tenokami would be great to connect

@tenokami
Copy link
Collaborator

tenokami commented Oct 6, 2023

@shelar1423 Are there requirements for the file type of these icons ?

@shelar1423
Copy link
Collaborator Author

@shelar1423 Are there requirements for the file type of these icons ?

I don't think so but a png or a svg can work good I feel

@tenokami
Copy link
Collaborator

tenokami commented Oct 6, 2023

@shelar1423 Could you please try using emojis like here https://github.com/novuhq/novu

and then send send a screenshot again?

@shelar1423
Copy link
Collaborator Author

Sure @tenokami will try and send

@shelar1423
Copy link
Collaborator Author

@tenokami i tried searching but I am unable to find emojis which match the content

@tenokami
Copy link
Collaborator

tenokami commented Oct 6, 2023

@shelar1423 hmm, I see. This could happen. Can you share me a site where I can view the whole list of these?

@shelar1423
Copy link
Collaborator Author

shelar1423 commented Oct 6, 2023

@shelar1423 hmm, I see. This could happen. Can you share me a site where I can view the whole list of these?

List of the emojis or the document which we are talking about? @tenokami

@tenokami
Copy link
Collaborator

tenokami commented Oct 6, 2023

@shelar1423 list of multicolored emojis to use as icons

@shelar1423
Copy link
Collaborator Author

@tenokami
Copy link
Collaborator

tenokami commented Oct 6, 2023

@shelar1423 Thank you. I don't really have much time atm. When I can i'll try too look for the ones that would fit.
Or you can try to suggest yours that would be modern, match each other stylisticaly and match link's purpose

@vercel
Copy link

vercel bot commented Oct 6, 2023

@shelar1423 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #437 (f88806f) into main (e108833) will not change coverage.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   17.50%   17.50%           
=======================================
  Files          59       59           
  Lines        2719     2719           
=======================================
  Hits          476      476           
  Misses       2243     2243           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shelar1423
Copy link
Collaborator Author

image
@tenokami @dartpain new icons

@shelar1423
Copy link
Collaborator Author

@dartpain lemme know it this matches our style ?

@tenokami
Copy link
Collaborator

tenokami commented Oct 7, 2023

They look a bit more modern now but still not similar to each other. I'll admit this is a tough task to do well. And taking the time to find the perfect icons might not be worth it. @dartpain your call

@dartpain
Copy link
Contributor

dartpain commented Oct 7, 2023

Lets just do emojis for everything except for discord icon
I propose
🔍🔥 live preview
discord remains
📚😎 guides
👩‍💻👨‍💻💪 contrib
🗂️🚀 documentation
🏠💾🔐 Locally

@tenokami
Copy link
Collaborator

tenokami commented Oct 7, 2023

@dartpain we can use this

@shelar1423
Copy link
Collaborator Author

Yeah @tenokami , sure @dartpain will be pushing it with emojis in a while

@shelar1423
Copy link
Collaborator Author

@tenokami @dartpain here's how it looks, and also can you assign this as PR the hacktoberfest-accepted or hacktoberfest tag?
image

@shelar1423
Copy link
Collaborator Author

@dartpain please have a review

@dartpain
Copy link
Contributor

dartpain commented Oct 8, 2023

Sorry for dragging this issue on for so long,
please update with this emojis, this is final

🔍🔥 live preview
💬🎉 for discord
📚😎 guides
👩‍💻👨‍💻 contrib
🗂️🚀 documentation
🏠🔐 Locally

@shelar1423
Copy link
Collaborator Author

@dartpain no worries, changed it to the final version ,hopefully it gets merged this time 😄
image

@dartpain
Copy link
Contributor

dartpain commented Oct 9, 2023

@holopin-bot @shelar1423 Thank you!

@holopin-bot
Copy link

holopin-bot bot commented Oct 9, 2023

Congratulations @shelar1423, you just earned a badge! Here it is: https://holopin.io/claim/clnj205jv08610gl8rc9di6r9

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain dartpain merged commit da81abc into arc53:main Oct 9, 2023
9 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants