Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindConstants() builtin function #178

Merged
merged 49 commits into from
May 3, 2024
Merged

Add bindConstants() builtin function #178

merged 49 commits into from
May 3, 2024

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Apr 23, 2024

Changes introduced with this PR

Add bindConstants() to the builtin functions.

input.yaml

repeated_inputs:
  a: A
  b: B
items:
- 1
- 2
bindConstants( [1, 2], {a: A, b: B} )
# [ { items: 1, constants: {a: A, b: B} },
#   { items: 2, constants: {a: A, b: B} } ]

By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader marked this pull request as ready for review April 24, 2024 13:43
@mfleader mfleader requested a review from webbnh April 24, 2024 14:32
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to ready. There are a few spots that I think could use more comments, and potentially some minor gaps in testing.

internal/builtinfunctions/functions.go Outdated Show resolved Hide resolved
internal/builtinfunctions/functions.go Outdated Show resolved Hide resolved
internal/builtinfunctions/functions.go Show resolved Hide resolved
internal/builtinfunctions/functions_test.go Outdated Show resolved Hide resolved
internal/builtinfunctions/functions_test.go Outdated Show resolved Hide resolved
internal/builtinfunctions/functions_test.go Outdated Show resolved Hide resolved
internal/builtinfunctions/functions_test.go Outdated Show resolved Hide resolved
internal/builtinfunctions/functions_test.go Show resolved Hide resolved
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

webbnh

This comment was marked as resolved.

@mfleader mfleader marked this pull request as draft May 1, 2024 17:27
@mfleader mfleader marked this pull request as ready for review May 1, 2024 19:12
@mfleader mfleader self-assigned this May 1, 2024
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to ready.

internal/builtinfunctions/functions_test.go Outdated Show resolved Hide resolved
internal/builtinfunctions/functions_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfleader mfleader merged commit 8a4265e into main May 3, 2024
5 checks passed
@mfleader mfleader deleted the fn-attach-constants branch May 3, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants