Enums for miscellaneous card parts #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the changes needed for Card and CardModel go in this PR too as part of the change? |
I was planning for that to be a separate PR after #80 is merged, as that's touching a whole lot of things in the same areas and I'd like to keep that merge clean. |
fjork3
changed the title
fjork3
changed the title
src/scooze/card.py
Outdated
| set_name: str = "", | ||
| set_search_uri: str = "", | ||
| set_type: str = "", | ||
| set_type: SetType = "", |
There was a problem hiding this comment.
SetType.NONE as default?
There was a problem hiding this comment.
Made None accepted and the default.
src/scooze/enums.py
Outdated
| @@ -55,6 +55,18 @@ class Color(ExtendedEnum, StrEnum): | |||
| GREEN = "G" | |||
|
|
|||
|
|
|||
| class Component(ExtendedEnum, StrEnum): | |||
| """ | |||
| A type of related object, used in Scryfall to link a card to other cards or tokens referenced by it. | |||
src/scooze/enums.py
Outdated
| @@ -106,6 +162,75 @@ class Game(ExtendedEnum, StrEnum): | |||
| MTGO = auto() | |||
|
|
|||
|
|
|||
| class ImageStatus(ExtendedEnum, StrEnum): | |||
| """ | |||
| An indicator for whether a card's image exists on Scryfall, and how high quality the sourced image is. | |||
src/scooze/enums.py
Outdated
| @@ -147,6 +272,50 @@ class ScryfallBulkFile(ExtendedEnum, StrEnum): | |||
| # TODO(#26): support for Rulings file | |||
|
|
|||
|
|
|||
| class SecurityStamp(ExtendedEnum, StrEnum): | |||
| """ | |||
| A holographic security stamp printed on the bottom of some Magic cards, generally rares and mythics. | |||
src/scooze/models/cardparts.py
Outdated
| default=None, | ||
| description="Foil price in Euros, from Cardmarket." | ||
| ) | ||
| eur_foil: float | None = Field(default=None, description="Foil price in Euros, from Cardmarket.") |
iambroadband
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component
Frame
FrameEffect
ImageStatus
Language
Layout
SecurityStamp
SetType