10855_change_precision_of_incoming_geoms #10922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryan86
commented
May 14, 2024
ryan86
commented
- Make precision reduction function recursive
- Separate bbox and precision/byte size validation
- Add tests
added 2 commits
May 1, 2024 16:55
chiatt
requested changes
May 15, 2024
arches/app/datatypes/datatypes.py
Outdated
| current_precision = abs(self.find_num(feature_geom.coords)) | ||
|
|
||
| geom = geo_utils.reduce_precision(geom, current_precision) | ||
| except: |
There was a problem hiding this comment.
It would be good to name the error that is being excepted here. That would clarify the code and prevent excepting any unexpected errors.
chiatt
approved these changes
May 16, 2024
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.