-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10855_change_precision_of_incoming_geoms #10922
Conversation
ryan86
commented
May 14, 2024
- Make precision reduction function recursive
- Separate bbox and precision/byte size validation
- Add tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just swung by to see if webpack was happier, noticed a couple things esp. in the tests.
arches/app/datatypes/datatypes.py
Outdated
current_precision = abs(self.find_num(feature_geom.coords)) | ||
|
||
geom = geo_utils.reduce_precision(geom, current_precision) | ||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to name the error that is being excepted here. That would clarify the code and prevent excepting any unexpected errors.