Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed Report Configs #5000

Merged
merged 8 commits into from
Jul 15, 2019
Merged

Tabbed Report Configs #5000

merged 8 commits into from
Jul 15, 2019

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Jul 12, 2019

Description of Change

Adds tabbed report configuration and removes deprecated report manager files re #4684, #3601

var newTab = {
icon: ko.observable(),
name: ko.observable(),
nodegroup_ids: ko.observableArray()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier 'nodegroup_ids' is not in camel case. (camelcase)

@coveralls
Copy link

coveralls commented Jul 12, 2019

Coverage Status

Coverage remained the same at ?% when pulling f7b440b on 4684_tabbed_report into 92c95c0 on master.

@chiatt chiatt merged commit 8285ab1 into master Jul 15, 2019
@chiatt chiatt deleted the 4684_tabbed_report branch August 23, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants