prettify contract error

archethic-foundation · Mar 15, 2023 · 48bcf6c · 48bcf6c
1 parent 736c775
commit 48bcf6c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/lib/archethic_web/controllers/api/transaction_controller.ex b/lib/archethic_web/controllers/api/transaction_controller.ex
@@ -192,11 +192,10 @@ defmodule ArchethicWeb.API.TransactionController do
                 "recipient_address" => Base.encode16(recipient)
               }
 
-            {{:exit, _reason}, recipient} ->
-              # TODO: find a way to prettify the error and remove the stacktrace
+            {{:exit, reason}, recipient} ->
               %{
                 "valid" => false,
-                "reason" => "A contract exited while simulating",
+                "reason" => format_exit_reason(reason),
                 "recipient_address" => Base.encode16(recipient)
               }
           end)
@@ -228,4 +227,22 @@ defmodule ArchethicWeb.API.TransactionController do
         {:error, reason}
     end
   end
+
+  defp format_exit_reason({error_atom, stacktrace}) do
+    Enum.reduce_while(
+      stacktrace,
+      "A contract exited with error: #{error_atom}",
+      fn
+        {:elixir_eval, _, _, [file: 'nofile', line: line]}, acc ->
+          {:halt, acc <> " (line: #{line})"}
+
+        _, acc ->
+          {:cont, acc}
+      end
+    )
+  end
+
+  defp format_exit_reason(_) do
+    "A contract exited with an unknown error"
+  end
 end
diff --git a/test/archethic_web/controllers/api/transaction_controller_test.exs b/test/archethic_web/controllers/api/transaction_controller_test.exs
@@ -192,11 +192,13 @@ defmodule ArchethicWeb.API.TransactionControllerTest do
           [
             %{
               "valid" => true,
-              "address" => "00009E059E8171643B959284FE542909F3B32198B8FC25B3E50447589B84341C1D66"
+              "recipient_address" =>
+                "00009E059E8171643B959284FE542909F3B32198B8FC25B3E50447589B84341C1D66"
             },
             %{
               "valid" => true,
-              "address" => "00009E059E8171643B959284FE542909F3B32198B8FC25B3E50447589B84341C1D67"
+              "recipient_address" =>
+                "00009E059E8171643B959284FE542909F3B32198B8FC25B3E50447589B84341C1D67"
             }
           ],
           json_response(conn, 200)