Do not initialize empty contract with empty conditions

lib/archethic/contracts/contract.ex

@@ -15,11 +15,7 @@ defmodule Archethic.Contracts.Contract do
 
   defstruct triggers: %{},
             version: 0,
-            conditions: %{
-              transaction: %Conditions{},
-              inherit: %Conditions{},
-              oracle: %Conditions{}
-            },
+            conditions: %{},
             constants: %Constants{},
             next_transaction: %Transaction{data: %TransactionData{}}
 

lib/archethic/contracts/interpreter.ex

@@ -485,11 +485,7 @@ defmodule Archethic.Contracts.Interpreter do
   end
 
   defp parse_contract(1, ast) do
-    # we need to force the initialization of conditions to an empty map
-    # to be able to detect that user did not omit some condition blocks
-    initial_contract = %Contract{conditions: %{}}
-
-    case parse_ast_block(ast, initial_contract) do
+    case parse_ast_block(ast, %Contract{}) do
       {:ok, contract} ->
         {:ok, %{contract | version: 1}}
 

lib/archethic/transaction_chain/mem_tables_loader.ex

@@ -67,13 +67,19 @@ defmodule Archethic.TransactionChain.MemTablesLoader do
   defp handle_pending_transaction(%Transaction{data: %TransactionData{code: ""}}), do: :ok
 
   defp handle_pending_transaction(tx = %Transaction{address: address}) do
-    %Contract{conditions: %{transaction: transaction_conditions}} = Contract.from_transaction!(tx)
+    %Contract{conditions: conditions} = Contract.from_transaction!(tx)
 
-    # TODO: improve the criteria of pending detection
-    if ContractConditions.empty?(transaction_conditions) do
-      :ok
-    else
-      PendingLedger.add_address(address)
+    case Map.get(conditions, :transaction) do
+      nil ->
+        :ok
+
+      transaction_conditions ->
+        # TODO: improve the criteria of pending detection
+        if ContractConditions.empty?(transaction_conditions) do
+          :ok
+        else
+          PendingLedger.add_address(address)
+        end
     end
   end
 

test/archethic/contracts_test.exs

@@ -21,6 +21,8 @@ defmodule Archethic.ContractsTest do
         content: "hello"
       ]
 
+      condition transaction: []
+
       actions triggered_by: transaction do
         add_uco_transfer to: "3265CCD78CD74984FAB3CC6984D30C8C82044EBBAB1A4FFFB683BDB2D8C5BCF9", amount: 1000000000
       end
@@ -59,6 +61,8 @@ defmodule Archethic.ContractsTest do
         content: regex_match?(\"hello\")
       ]
 
+      condition transaction: []
+
       actions triggered_by: transaction do
         set_content "hello"
       end

test/archethic/transaction_chain/mem_tables_loader_test.exs

@@ -43,6 +43,8 @@ defmodule Archethic.TransactionChain.MemTablesLoaderTest do
                  previous_public_key: "Contract1",
                  data: %TransactionData{
                    code: """
+                   condition inherit: []
+
                    condition transaction: [
                      content: regex_match?(\"hello\")
                    ]