Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset crashes if the get_network_patches timeouts #1081

Closed
samuelmanzanera opened this issue Jun 9, 2023 · 0 comments
Closed

Subset crashes if the get_network_patches timeouts #1081

samuelmanzanera opened this issue Jun 9, 2023 · 0 comments
Labels
beacon chain Involve BeaconChain bug Something isn't working
Milestone

Comments

@samuelmanzanera
Copy link
Member

Describe the problem you discovered

During the summary creation of the BeaconChain, if the get_network_patches timeouts, the Task.async/await crashed after 5s.
This seems due to not supervised task.

Describe the solution you'd like

We should use Task.Supervisor. async_nolink to avoid blowing up the subset's process and we should help to catch the timeout with Task.yield(task, timeout) || Task.shutdown(task)

Epic

#215

@samuelmanzanera samuelmanzanera added bug Something isn't working beacon chain Involve BeaconChain labels Jun 9, 2023
@samuelmanzanera samuelmanzanera added this to the 1.1.1 milestone Jun 9, 2023
@Neylix Neylix closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants