Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONRPC transaction.content should not be base16 anymore #1232

Closed
bchamagne opened this issue Aug 29, 2023 · 3 comments · Fixed by #1238
Closed

JSONRPC transaction.content should not be base16 anymore #1232

bchamagne opened this issue Aug 29, 2023 · 3 comments · Fixed by #1238
Assignees
Labels
feature New feature request
Milestone

Comments

@bchamagne
Copy link
Member

Is your feature request related to a problem?

When using the REST API, we'd have to base16 the transaction.content. This was a legacy decision.

Describe the solution you'd like

Now that we have a new API we can remove that legacy

Additional context

No response

Epic

No response

@bchamagne bchamagne added the feature New feature request label Aug 29, 2023
@bchamagne bchamagne added this to the 1.3.0 milestone Aug 29, 2023
@samuelmanzanera
Copy link
Member

We can probably use the switch from Ecto the JSON RPC schema validation to simplify the migration, as it might be complex to use either Hex for legacy REST API and type of the JSON RPC API.

@Neylix Neylix self-assigned this Aug 30, 2023
@Neylix
Copy link
Member

Neylix commented Aug 30, 2023

We can probably use the switch from Ecto the JSON RPC schema validation to simplify the migration, as it might be complex to use either Hex for legacy REST API and type of the JSON RPC API.

Since we planned to use OpenRPC standard #1220
I think we could temporarily add a flag in Ecto has it will be deleted soon with OpenRPC implementation

@samuelmanzanera
Copy link
Member

We can probably use the switch from Ecto the JSON RPC schema validation to simplify the migration, as it might be complex to use either Hex for legacy REST API and type of the JSON RPC API.

Since we planned to use OpenRPC standard #1220 I think we could temporarily add a flag in Ecto has it will be deleted soon with OpenRPC implementation

I think it might require another type in Ecto.Schema instead of Hex, to support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants