Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json RPC endpoint does not require content to be base16 #1238

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Aug 31, 2023

Description

Remove the base16 format for the transaction content.

Created new Json Schema validation method.

Fixes #1232

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added API Involve API facing user breaking change Identify a change with a breaking API labels Aug 31, 2023
@Neylix Neylix added this to the 1.3.0 milestone Aug 31, 2023
}
]
},
"maxItems": 255
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelmanzanera What are you thoughts on this maxItems=255? In the serialization we have no such limitation

@bchamagne bchamagne merged commit 8c7d60d into archethic-foundation:develop Sep 1, 2023
2 checks passed
@Neylix Neylix deleted the Remove-content-base16 branch September 1, 2023 09:50
@Neylix Neylix added enhancements and removed breaking change Identify a change with a breaking API labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONRPC transaction.content should not be base16 anymore
2 participants