Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sef default max confirmation in transaction subscriber #522

Closed
ghost opened this issue Aug 17, 2022 · 1 comment · Fixed by #529
Closed

Sef default max confirmation in transaction subscriber #522

ghost opened this issue Aug 17, 2022 · 1 comment · Fixed by #529
Labels
API Involve API facing user bug Something isn't working

Comments

@ghost
Copy link

ghost commented Aug 17, 2022

Describe the problem you discovered

It can happens when the the transaction confirmation subscription is sent after the transaction submit, and the max confirmation is set to 0.
This is cause inconsistency in the client applications, because they cannot know how many confirmations to wait.

Describe the solution you'd like

So we should leverage the max_confirmations by default
@ghost ghost added bug Something isn't working API Involve API facing user labels Aug 17, 2022
This was referenced Aug 17, 2022
Closed
Merged
@ghost
Copy link
Author

ghost commented Aug 18, 2022

Closed by #529

@ghost ghost closed this as completed Aug 18, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Involve API facing user bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix max confirmations archethic-foundation/archethic-node
0 participants