Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max confirmations #529

Merged
1 commit merged into from
Aug 18, 2022
Merged

Fix max confirmations #529

1 commit merged into from
Aug 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2022

Description

Set the default max confirmations in case of the subscription happens after the transaction sending

Fixes #522

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost changed the base branch from master to develop August 18, 2022 14:47
@ghost ghost added bug Something isn't working API Involve API facing user labels Aug 18, 2022
@ghost ghost requested a review from imnik11 August 18, 2022 14:47
@apoorv-2204 apoorv-2204 self-requested a review August 18, 2022 16:03
@ghost ghost merged commit b14e7c5 into develop Aug 18, 2022
@ghost ghost deleted the fix_max_confirmations branch August 18, 2022 19:19
@ghost ghost mentioned this pull request Aug 18, 2022
Closed
ghost pushed a commit that referenced this pull request Aug 25, 2022
Set default max confirmations (#529)
f8dc5f8
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Involve API facing user bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sef default max confirmation in transaction subscriber
3 participants
@Neylix @imnik11 @apoorv-2204