Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the validity of addresses in the SC statements #616

Closed
Tracked by #843
samuelmanzanera opened this issue Oct 10, 2022 · 2 comments
Closed
Tracked by #843

Check the validity of addresses in the SC statements #616

samuelmanzanera opened this issue Oct 10, 2022 · 2 comments
Assignees
@apoorv-2204
Labels
bug Something isn't working good first issue Good for newcomers smart contracts Involve smart contracts

Comments

@samuelmanzanera
Copy link
Member

samuelmanzanera commented Oct 10, 2022 •
edited
Loading

In the SC SDK, we have some transaction statements to build a new transaction.
We are performing check whether the hex is valid or not, but not discard the statement results if the hex is not valid.
We should check if the hex is valid and prevent the assignment of the statement if not.
Furthermore, we should also check whether the addresses are valid or not.

Epic: #608
@samuelmanzanera samuelmanzanera added bug Something isn't working smart contracts Involve smart contracts labels Oct 10, 2022
@samuelmanzanera samuelmanzanera mentioned this issue Oct 10, 2022
Open
@samuelmanzanera samuelmanzanera added the good first issue Good for newcomers label Nov 16, 2022
@internet-zero
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @apoorv-2204 @netboz @Neylix @samuelmanzanera @tenmoves

@bchamagne
Copy link
Member

Please add your planning poker estimate with Zenhub @bchamagne

@apoorv-2204 apoorv-2204 self-assigned this Jan 17, 2023
This was referenced Jan 18, 2023
Merged
Merged
Neylix added a commit that referenced this issue Jan 30, 2023
@apoorv-2204 @Neylix
Check the validity of addresses in the SC statements #616 (#843)
ba126bc 
* check_the_validity_of_addresses_in_the_SC_statements

* remove troubling comment

* Check validity of public key in smart_contract

---------

Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorv-2204 apoorv-2204

Labels
bug Something isn't working good first issue Good for newcomers smart contracts Involve smart contracts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samuelmanzanera @bchamagne @internet-zero @apoorv-2204