Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check transaction's address existence during validation #678

Closed
samuelmanzanera opened this issue Nov 10, 2022 · 1 comment · Fixed by #682
Closed

Check transaction's address existence during validation #678

samuelmanzanera opened this issue Nov 10, 2022 · 1 comment · Fixed by #682
Assignees
Labels
core team Assigned to the core team enhancements mining Involve transaction validation and mining

Comments

@samuelmanzanera
Copy link
Member

Is your feature request related to a problem?

For now, the transaction's address existence is checked on the replication nodes
It might occur – due to network failure, sync failure or split brain – two transaction with the same address are replicated by the network, causing chain inconsistency and therefore invalid proof of integrity for the chain by the next transaction.

Describe the solution you'd like

So to increase consistency in the transaction validation across multiple cross validation nodes, the existence should also be checked in the validation stamp.
We can add in the pending transaction validation a check to ensure the transaction is not already replicated and store this error result in the validation stamp.

Additional context

No response

@samuelmanzanera samuelmanzanera added mining Involve transaction validation and mining enhancements labels Nov 10, 2022
@internet-zero
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @samuelmanzanera @apoorv-2204 @Neylix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team Assigned to the core team enhancements mining Involve transaction validation and mining
Projects
None yet
2 participants