Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if transaction already exists during transaction validation #682

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

Trying to send the same transaction from the node should be prevented during transaction validation by checking the existence of the transaction

Fixes #678

Type of change

  • Enhancement

How Has This Been Tested?

If you send an existing transaction from the node an error should be triggered.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added mining Involve transaction validation and mining enhancements labels Nov 14, 2022
@samuelmanzanera samuelmanzanera force-pushed the check_tx_address_existence branch 2 times, most recently from 2ad69f0 to 6f6da4e Compare November 15, 2022 08:42
lib/archethic.ex Outdated Show resolved Hide resolved
@samuelmanzanera samuelmanzanera force-pushed the check_tx_address_existence branch 3 times, most recently from 4f018d2 to 08ed959 Compare November 17, 2022 09:37
@samuelmanzanera samuelmanzanera changed the title Check if transaction already during transaction validation Check if transaction already exists during transaction validation Nov 17, 2022
@samuelmanzanera samuelmanzanera merged commit 77d6bef into develop Nov 17, 2022
@samuelmanzanera samuelmanzanera deleted the check_tx_address_existence branch November 17, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check transaction's address existence during validation
2 participants