Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of validation nodes should not be more than replica number #695

Closed
Neylix opened this issue Nov 17, 2022 · 0 comments · Fixed by #722
Closed

Number of validation nodes should not be more than replica number #695

Neylix opened this issue Nov 17, 2022 · 0 comments · Fixed by #722
Assignees
Labels
bug Something isn't working mining Involve transaction validation and mining

Comments

@Neylix
Copy link
Member

Neylix commented Nov 17, 2022

Describe the problem you discovered

In the consensus we have an election for storage nodes and for validation nodes. In the consensus we should not have more validation nodes than storage nodes.
In some case it is actually possible according to the amount of a transaction

Describe the solution you'd like

In the election of validation nodes, we should also verify that the number of validation nodes is <= of the storage nodes number.

In the same time, we can remove the sort by authorized nodes in the storage nodes election as this sort is overwritten by the rotating key sort just after

@Neylix Neylix added bug Something isn't working mining Involve transaction validation and mining labels Nov 17, 2022
@bchamagne bchamagne self-assigned this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants