Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure there is never more validation nodes than storage nodes #722

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Ensure there is never more validation nodes than storage nodes #722

merged 5 commits into from
Nov 30, 2022

Conversation

bchamagne
Copy link
Member

@bchamagne bchamagne commented Nov 28, 2022 •
edited
Loading

Description

On the validation nodes' election, we have to make sure we never have more validation nodes than storage nodes.

Fixes #695

Type of change

  • Bug fix

How Has This Been Tested?

Test added to the suite.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added mining Involve transaction validation and mining core team Assigned to the core team enhancements labels Nov 29, 2022
@samuelmanzanera samuelmanzanera merged commit cde433d into archethic-foundation:develop Nov 30, 2022
tenmoves pushed a commit to tenmoves/archethic-node that referenced this pull request Dec 6, 2022
@bchamagne @tenmoves
Ensure there is never more validation nodes than storage nodes (arche…
8baecf4 
…thic-foundation#722)

* Ensure there is never more validation nodes than storage nodes

and remove an obsolete sort

* Add tests to check validation nodes <= storage nodes

* Move the logic directly in the election function

* lint

* clean tests' tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neylix Neylix Neylix approved these changes

Assignees
No one assigned
Labels
core team Assigned to the core team enhancements mining Involve transaction validation and mining
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of validation nodes should not be more than replica number
3 participants
@bchamagne @Neylix @samuelmanzanera