Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send replication message if validation has error #696

Closed
Neylix opened this issue Nov 17, 2022 · 0 comments · Fixed by #718
Closed

Do not send replication message if validation has error #696

Neylix opened this issue Nov 17, 2022 · 0 comments · Fixed by #718
Assignees
Labels
bug Something isn't working mining Involve transaction validation and mining replication

Comments

@Neylix
Copy link
Member

Neylix commented Nov 17, 2022

Describe the problem you discovered

Actually whenever the validation of a transaction has error or not, we send the replication message to the storage nodes.
But if there is an error in the validation, the storage nodes will not replicate the transaction. So we send a message for nothing because we already know that the replication will fail

Describe the solution you'd like

In the distributed workflow, if there is an error in the validation stamp or in the cross validation stamp, then do not send the replication message to the storage node, and directly notify the error to the welcome node.

@Neylix Neylix added bug Something isn't working mining Involve transaction validation and mining replication labels Nov 17, 2022
@bchamagne bchamagne self-assigned this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mining Involve transaction validation and mining replication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants