Skip replication if there is a (cross)validation error #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmanzanera
added
bug
and remove the cross validation inconsistency in the test on validation stamp
Neylix
reviewed
Nov 29, 2022
Neylix
approved these changes
Nov 30, 2022
validation_stamp will have an error if it's the case
samuelmanzanera
approved these changes
Dec 2, 2022
Neylix
approved these changes
Dec 2, 2022
tenmoves
pushed a commit
to tenmoves/archethic-node
that referenced
this pull request
Dec 6, 2022
…dation#718) It also includes: * stop the FSM in case of consensus_not_reached * Validation will check for sufficient funds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the distributed workflow, if there is an error in the validation stamp or in the cross validation stamp, then do not send the replication messages to the storage nodes, and directly notify the error to the welcome node.
notify_errorused to be an internal event but we had to change this to a function to be able to use it from thereplication.state_entercallback.Fixes #696
IMPORTANT NOTE: The scenario
:insufficient_fundsis not checked in the distributed_workflow. This means a transaction from an address with insufficient funds will not mark the stamps as invalid and the transaction will be replicated to the storage nodes where they'll be discarded.Type of change
How Has This Been Tested?
Tests added to the suite.
Scenario tested on the transaction builder (with 3 nodes): Creation of a token with an invalid JSON. You should see the usual error and you should see a "skipped replication" in the logs.
Checklist: