Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new types of transaction #726

Closed
2 tasks
samuelmanzanera opened this issue Nov 30, 2022 · 1 comment
Closed
2 tasks

Add new types of transaction #726

samuelmanzanera opened this issue Nov 30, 2022 · 1 comment
Assignees
@apoorv-2204
Labels
transaction Involve transactions

Comments

@samuelmanzanera
Copy link
Member

We should add new type of transaction to provide better meaning of the transaction.
The new types should be:

  • Data
  • Contract

Those types should also be validated with the following policy:

  • Contract: should contain at least smart code
  • Data: should contain some data, either in the content or secrets

This is also related #409
@samuelmanzanera samuelmanzanera added the transaction Involve transactions label Nov 30, 2022
@apoorv-2204 apoorv-2204 self-assigned this Dec 19, 2022
@apoorv-2204
Copy link
Contributor

apoorv-2204 commented Dec 19, 2022 •
edited
Loading

may be storage instead of data what you think?

This was referenced Jan 12, 2023
Closed
Closed
Neylix added a commit that referenced this issue Jan 13, 2023
@apoorv-2204 @Neylix
Add New Types of Transaction #726 (#791)
0a59a85 
* basic rules for new type txns

* remove unneccesary data

* minor changes

* update to upnpc

* - add checks for ownerships in all txns,
- check for byte size data should not exceed txn content size

* update tests

* review changes

* refactor for r,c,m

* add serialization

* refactor validation tests

* temp

* tests

* review changes

* review Changes

* Few improvements for logging and pattern matching

Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorv-2204 apoorv-2204

Labels
transaction Involve transactions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samuelmanzanera @apoorv-2204