Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite looping in forward transaction #931

Closed
bchamagne opened this issue Mar 13, 2023 · 0 comments · Fixed by #937
Closed

Infinite looping in forward transaction #931

bchamagne opened this issue Mar 13, 2023 · 0 comments · Fixed by #937
Assignees
Labels
bug Something isn't working core team Assigned to the core team mining Involve transaction validation and mining

Comments

@bchamagne
Copy link
Member

bchamagne commented Mar 13, 2023

Describe the problem you discovered

There might be some scenario where the forward transaction mechanism leads to infinite looping.

For example:
Imagine there are N nodes, and they all are synchronized but NODE_1 and NODE_2 (they are available).

Screenshot 2023-03-13 at 11-41-46 Online FlowChart   Diagrams Editor - Mermaid Live Editor

NODE_1 get send_new_tx call, here 2 possibilities:
1/ tx is forwarded to NODE_2 (SEE BELOW)
4/ tx is forwarded to NODE_1 (= INFINITE LOOP)

Lets continue after 1/, there are 3 possibilities here:
2/ tx is forwarded to NODE_1 (= INFINITE LOOP)
3/ tx is forwarded to NODE_2 (=INFINITE LOOP)
5/ tx is forwarded to NODE_N (OK)

Describe the solution you'd like

No response

@bchamagne bchamagne added bug Something isn't working core team Assigned to the core team labels Mar 13, 2023
@bchamagne bchamagne added the mining Involve transaction validation and mining label Mar 13, 2023
@samuelmanzanera samuelmanzanera linked a pull request Mar 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core team Assigned to the core team mining Involve transaction validation and mining
Projects
Status: Done 🍻
Development

Successfully merging a pull request may close this issue.

2 participants