-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve_synchronization_when_node_ip_changes_#887 #930
Merged
Neylix
merged 1 commit into
archethic-foundation:develop
from
apoorv-2204:improve_synchronization_when_node_ip_changes_#887
Mar 31, 2023
Merged
improve_synchronization_when_node_ip_changes_#887 #930
Neylix
merged 1 commit into
archethic-foundation:develop
from
apoorv-2204:improve_synchronization_when_node_ip_changes_#887
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1b0ce1
to
21037c7
Compare
d0fda0c
to
6bd1c9d
Compare
samuelmanzanera
approved these changes
Mar 16, 2023
Neylix
requested changes
Mar 17, 2023
bchamagne
requested changes
Mar 20, 2023
aa2d7f4
to
677a627
Compare
677a627
to
c1ae5be
Compare
samuelmanzanera
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems ok
bchamagne
approved these changes
Mar 27, 2023
|
||
types = [:node, :oracle, :node_shared_secrets, :reward] | ||
|
||
Task.Supervisor.async_stream_nolink(Archethic.TaskSupervisor, types, fn type -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #933 merge, you'd need to use NetworkChain.asynchronous_resync_many(network_chain_types)
instead.
Neylix
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a node's IP address changes, a new transaction (TX) is generated, but an unusual problem arises: the node becomes invisible to other nodes due to the IP change. While the node with the new IP can create a node TX, it must wait for replication and load the last node public key, which fails because it cannot access the TX it created. The solution involves manually waiting for confirmation and initiating a self-repair process.
Fixes
Type of change
Please delete options that are not relevant.
Checklist: