Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contracts: Do not schedule an interval tick if there is a datetime tick at the same time #1015

Conversation

bchamagne
Copy link
Member

Description

This is required for #929. I extracted it from there.
Currently, when there is one interval trigger that ticks at the same time at as datetime trigger. They both run concurrently but only 1 can actually create the transaction. The other will get a transaction already mining issue.
This PR fix this by not scheduling an interval tick if there is a datetime tick.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual test with this contract:

@version 1

condition inherit: [ content: true ] 

actions triggered_by: interval, at: "* * * * *" do 
  Contract.set_content("interval")
end

actions triggered_by: datetime, at: 1683272596 do 
  Contract.set_content("datetime")
end

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working smart contracts Involve smart contracts labels May 5, 2023
@bchamagne bchamagne added this to the v.1.0.8-rc2 milestone May 5, 2023
@samuelmanzanera samuelmanzanera merged commit 0e6371d into archethic-foundation:develop May 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

None yet

3 participants